eslint cleanup; trailing comma fix for IE #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aaronshaf
commented
Jul 25, 2014
aaronshaf
commented
- Removed unused variables
- Removed double declarations
- Most importantly, removed trailing comma which was breaking IE
- Added eslint.json for future eslint usage
- Removed unused variables - Removed double declarations - Most importantly, removed trailing commas which were breaking IE - Added eslint.json for future eslint usage
| @@ -422,7 +422,7 @@ function checkTransitionFromHooks(matches, transition) { | |||
| function checkTransitionToHooks(matches, transition) { | |||
| var promise = Promise.resolve(); | |||
|
|
|||
| matches.forEach(function (match, index) { | |||
There was a problem hiding this comment.
I personally think it's better to keep these unused function arguments.
mjackson
added a commit
that referenced
this pull request
Jul 25, 2014
eslint cleanup; trailing comma fix for IE
|
@mjackson lets make sure to check the |
|
@rpflorence ah yeah, sorry. Still not quite used to that so I forget sometimes :/ |
|
its okay, I still got it in 6bfcdfc |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.