Skip to content

Honor --mode flag in routes.ts context #13485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 29, 2025
Merged

Conversation

markdalgleish
Copy link
Member

@markdalgleish markdalgleish commented Apr 28, 2025

Fixes #12514

When passing a custom --mode flag to the React Router CLI, this was honoured in app code when accessing import.meta.env.MODE, but routes.ts was being executed in vite-node with the mode always set to development or production depending on the CLI command. This PR updates it so we default to the current values, but always use the --mode flag value if it's been provided.

Copy link

changeset-bot bot commented Apr 28, 2025

🦋 Changeset detected

Latest commit: a14dc8b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@react-router/dev Patch
@react-router/fs-routes Patch
@react-router/remix-routes-option-adapter Patch
create-react-router Patch
react-router Patch
react-router-dom Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@markdalgleish markdalgleish changed the base branch from main to dev April 29, 2025 01:31
@markdalgleish markdalgleish merged commit a548ae3 into dev Apr 29, 2025
8 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/routes-mode branch April 29, 2025 05:36
Copy link
Contributor

github-actions bot commented May 8, 2025

🤖 Hello there,

We just published version 7.6.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 7.6.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite MODE when evaluating routes.ts is production/development, not what’s passed via --mode
1 participant