Fix assetsDir
in entryFileNames
with Vite Env API
#13491
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13430
When
future.unstable_viteEnvironmentApi
is enabled, we were respecting the value forenvironments.client.build.assetsDir
when configuringbuild.rollupOptions.output.entryFileNames
, but we weren't falling back to the top-levelbuild.assetsDir
if it was missing.This PR updates the logic so that the
assetsDir
value falls back tobuild.assetsDir
ifenvironments.client.build.assetsDir
is not provided, before finally falling back to the default value of"assets"
.