Skip to content

Fix assetsDir in entryFileNames with Vite Env API #13491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2025

Conversation

markdalgleish
Copy link
Member

Fixes #13430

When future.unstable_viteEnvironmentApi is enabled, we were respecting the value for environments.client.build.assetsDir when configuring build.rollupOptions.output.entryFileNames, but we weren't falling back to the top-level build.assetsDir if it was missing.

This PR updates the logic so that the assetsDir value falls back to build.assetsDir if environments.client.build.assetsDir is not provided, before finally falling back to the default value of "assets".

Copy link

changeset-bot bot commented Apr 29, 2025

🦋 Changeset detected

Latest commit: 4704e00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@react-router/dev Patch
@react-router/fs-routes Patch
@react-router/remix-routes-option-adapter Patch
create-react-router Patch
react-router Patch
react-router-dom Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@markdalgleish markdalgleish merged commit 6f6f1c6 into dev Apr 29, 2025
10 of 11 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/vite-env-build-assets-dir branch April 29, 2025 09:30
Copy link
Contributor

github-actions bot commented May 8, 2025

🤖 Hello there,

We just published version 7.6.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite V6 - [Environment API] build.assetsDir is not fully respected in the client environment
1 participant