Skip to content

feat(react-router): don't bundle react-router in react-router/dom export #13497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 1, 2025
Merged

feat(react-router): don't bundle react-router in react-router/dom export #13497

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b2bc694
Don't bundle react-router in react-router/dom export
brophdawg11 Apr 29, 2025
84425ce
Add externals to ESM build and remove unneeded react externals
brophdawg11 Apr 30, 2025
fc893df
Fix e2e tests
brophdawg11 Apr 30, 2025
1fc71ae
Remove console
brophdawg11 Apr 30, 2025
220239f
Remove blank line
brophdawg11 Apr 30, 2025
87d545c
Don't include external in ESM config
brophdawg11 May 1, 2025
488e330
Revert "Fix e2e tests"
brophdawg11 May 1, 2025
818f8e0
Add unit test
brophdawg11 May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/breezy-pets-hug.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"react-router": patch
---

Don't bundle `react-router` in `react-router/dom` CJS export
1 change: 1 addition & 0 deletions packages/react-router/tsup.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const config = (enableDevWarnings: boolean) =>
{
clean: false,
entry,
external: ["react", "react-dom", "react-router"],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only added this for the CJS config because the ESM build wasn't bundling react-router - but this can be added to both configs is that's safer

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if it's redundant due to the way tsup is treating the ESM build differently to the CJS build, IMO it feels safer and more explicit to define the same externals everywhere.

Also, I think react and react-dom are redundant in this array. I ran the build locally without these and the require("react") and require("react-dom") calls were still there. The tsup docs say that external is for configuring additional externals, not replacing the default: https://tsup.egoist.dev/#excluding-packages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh good catch - I noticed they weren't bundled originally but wasn't entirely sure why so included them out of an abundance of caution. Good to know that is expected/documented behavior 👍

format: ["cjs"],
outDir: enableDevWarnings ? "dist/development" : "dist/production",
dts: true,
Expand Down