Detect and handle leading double slash paths #13510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 02605c5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was
linked to
issues
Apr 30, 2025
brophdawg11
force-pushed
the
brophdawg11/double-slash
branch
from
e3771c7 to
02605c5
Compare
brophdawg11
commented
Apr 30, 2025
Comment on lines
+751
to
+759
| // If this isn't a usage for absolute URLs (currently only for redirects), | ||
| // then we need to avoid the URL constructor treating a leading double slash | ||
| // as a protocol-less URL. By prepending the base, it forces the double slash | ||
| // to be parsed correctly as part of the pathname. | ||
| if (!isAbsolute && href.startsWith("//")) { | ||
| // new URL('//', 'https://localhost') -> error! | ||
| // new URL('https://localhost//', 'https://localhost') -> no error! | ||
| href = base + href; | ||
| } |
There was a problem hiding this comment.
This is the new behavior - which we don't want to apply to cases where we want to create an absolute URL, so we extract this utility for direct usage in the redirect case where we have an absolute URL.
This was referenced May 6, 2025
|
🤖 Hello there, We just published version Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11188
Closes #11429
Closes #11911