Skip to content

Skip unused routes.ts eval before Vite build #13513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

markdalgleish
Copy link
Member

Fixes #13078

We currently load the React Router config before starting the Vite build, but this is only done to load the future flags so we know whether to use the Vite Environment API powered build process or not. However, our config loading logic also evaluates routes.ts.

As a slight performance improvement and to keep the order of operations as similar as possible to react-router dev and vite build, we now skip evaluating routes.ts when loading future flags before the Vite build is started.

Copy link

changeset-bot bot commented May 1, 2025

🦋 Changeset detected

Latest commit: ab0e85b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@react-router/dev Patch
@react-router/fs-routes Patch
@react-router/remix-routes-option-adapter Patch
create-react-router Patch
react-router Patch
react-router-dom Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@markdalgleish markdalgleish linked an issue May 1, 2025 that may be closed by this pull request
@markdalgleish markdalgleish merged commit edb5fbe into dev May 1, 2025
10 of 11 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/skip-unused-routes-eval branch May 1, 2025 06:42
Copy link
Contributor

github-actions bot commented May 8, 2025

🤖 Hello there,

We just published version 7.6.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RR Vite plugin build command lifecycle differs from the dev one
1 participant