Skip to content

Fix prop types on route components #2470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2015
Merged

Fix prop types on route components #2470

merged 1 commit into from
Nov 4, 2015

Conversation

taion
Copy link
Contributor

@taion taion commented Nov 4, 2015

wat

@taion taion changed the title Remove orphaned prop type from Route components Fix prop types on route components Nov 4, 2015
@taion
Copy link
Contributor Author

taion commented Nov 4, 2015

ignoreScrollBehavior no longer does anything. getComponent was missing and should probably be there (it's in the API docs).

@knowbody
Copy link
Contributor

knowbody commented Nov 4, 2015

wow, good spot.

knowbody added a commit that referenced this pull request Nov 4, 2015
@knowbody
Merge pull request #2470 from taion/remove-dead-prop
88b35d8 
Fix prop types on route components
@knowbody knowbody merged commit 88b35d8 into remix-run:master Nov 4, 2015
@taion taion deleted the remove-dead-prop branch November 4, 2015 17:43
@taion
Copy link
Contributor Author

taion commented Nov 4, 2015

I was grepping for "scroll" and had to double-check that these props actually were orphaned.

@taion taion mentioned this pull request Nov 4, 2015
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taion @knowbody