Skip to content

Fix build configs #2535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 13, 2015
Merged

Fix build configs #2535

merged 3 commits into from
Nov 13, 2015

Conversation

taion
Copy link
Contributor

@taion taion commented Nov 12, 2015

This is the rest of #2517, &c. Largely no-op but we should merge to clean/freshen these.

@mjackson
Copy link
Member

Please match existing code style in .travis.yml as well.

@taion
Copy link
Contributor Author

taion commented Nov 12, 2015

This is actually the code style used by Travis in their guides though: http://docs.travis-ci.com/user/languages/javascript-with-nodejs/.

I'm fine with changing it back, but I'd think it'd generally be better to be consistent with upstream styling there.

@mjackson
Copy link
Member

Yes, please change it back and just add the lines we need for the cache.
Thanks!

On Thu, Nov 12, 2015 at 4:11 PM Jimmy Jia [email protected] wrote:

This is actually the code style used by Travis in their guides though:
http://docs.travis-ci.com/user/languages/javascript-with-nodejs/.

I'm fine with changing it back, but I'd think it'd generally be better to
be consistent with upstream styling there.


Reply to this email directly or view it on GitHub
#2535 (comment).

@taion
Copy link
Contributor Author

taion commented Nov 12, 2015

Updated both here and for the corresponding PR on history - unless you specifically want the Node version dialed back to "4" instead of stable.

mjackson added a commit that referenced this pull request Nov 13, 2015
@mjackson mjackson merged commit c524b1c into remix-run:master Nov 13, 2015
@mjackson
Copy link
Member

Thank you, @taion!

@taion taion deleted the fix-configs branch November 13, 2015 04:58
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants