Links apathetic to active don't subscribe (#3985)

[pshrmn]

When a <Link> doesn't need to know about the current location, its <a> does not need to be wrapped with a <LocationSubscriber>.
#3985

[pshrmn]

I did not include any tests because I am not sure exactly how to test this. There shouldn't be any differences in the DOM and I don't believe that there is a way to access the number of subscribers that the <Broadcast> component has.

[timdorr]

Needs a test case.

[timdorr]

Looks like this would obviate #3896, no?

[pshrmn]

Added tests. I'm not crazy about the import * as broadcasters from '../locationBroadcast' line, but I needed a target object to spy on.

[ryanflorence]

tim it first checks if we even care about being active, which is the only
time it matters, i'm still thinking about this one, but i'm inclined to
merge as is
On Sun, Oct 2, 2016 at 11:18 AM Paul Sherman [email protected]
wrote:

Added tests. I'm not crazy about the import * as broadcasters from
'../locationBroadcast' line, but I needed a target object to spy on.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#3986 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGHaN4brFHAW2ZNlyGDaCkLFuMnxEu9ks5qv_V0gaJpZM4KL7eK
.

[timdorr]

LGTM. @ryanflorence let me know if you want to add this or not.

[ryanflorence]

I'm going to merge this, but I intend to refactor it a bit right after, so I'm not going to merge until then.

[pshrmn]

rebased

[timdorr]

Still LGTM 😛