Skip to content

[DO NOT MERGE] Add test for transition to with basename #4008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 61 additions & 0 deletions modules/__tests__/integration-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -483,3 +483,64 @@ describe('Redirect', () => {
expect(replaces.length).toEqual(0)
})
})

describe('Basename support', () => {
const leftClickEvent = {
defaultPrevented: false,
preventDefault() { this.defaultPrevented = true },
metaKey: null,
altKey: null,
ctrlKey: null,
shiftKey: null,
button: 0
}

it('supports a target that starts with a slash', () => {
const div = document.createElement('div')
const TARGET = '/bar'
const BASENAME = "/foo"
const TEXT = 'You are on page bar.'

render((
<Router basename={BASENAME}>
<div>
<Link id="target" to={TARGET}>{TARGET}</Link>
<Match pattern={TARGET} render={() => (
<h2>{TEXT}</h2>
)}/>
</div>
</Router>
), div)

const href = div.querySelector('a').getAttribute('href')
expect(href).toEqual('/foo/bar')

Simulate.click(div.querySelector('#target'), leftClickEvent)
expect(div.innerHTML).toContain(TEXT)

})

it('supports a target that does not start with a slash', () => {
const div = document.createElement('div')
const TARGET = 'bar'
const BASENAME = "/foo"
const TEXT = 'You are on page bar.'

render((
<Router basename={BASENAME}>
<div>
<Link id="target" to={TARGET}>{TARGET}</Link>
<Match pattern={TARGET} render={() => (
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll probably have to add a leading slash to the pattern here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged remix-run/history@df60c49 into history today which automatically takes care of this in the history lib.

<h2>{TEXT}</h2>
)}/>
</div>
</Router>
), div)

const href = div.querySelector('a').getAttribute('href')
expect(href).toEqual('/foo/bar')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but the href is /foobar.


Simulate.click(div.querySelector('#target'), leftClickEvent)
expect(div.innerHTML).toContain(TEXT)
})
})