Failing test for <Miss /> with 'Blocker' component

[alisd23]

Refers to issue #4035

[pshrmn]

done should be an argument to the it callback, not describe

[alisd23]

Ah yes good catch, thanks

[ryanflorence]

alright, I'm digging in on this today

[ryanflorence]

afaict Miss works fine on master since we added the <LocationSubscriber> to it, I think the test is trolling you, if you click around the examples it works fine. Feel free to reopen if you find something, I'm just cleaning house here.

[alisd23]

Updated to current v4 master, and test still fails. Same issue with <Blocker> causing removeMatch to be called too late, which means notifySubscribers has already fired with the incorrect match information and <Miss> has already re-rendered.

Mentioned in more detail in #4035.
This PR fixes the issue I believe - #4067

[ryanflorence]

I know the test fails, but if you click around the examples w/ a <Blocker/> it still works. Can you confirm?

[pshrmn]

Try this app adapted from the test. When you navigate directly to / or /other, they render as expected, but when clicking the links they don't.

import React from 'react'
import { Match, Miss, Link, HashRouter } from 'react-router'

class Blocker extends React.Component {
  shouldComponentUpdate() {
    return false
  }

  render() {
    return <App />
  }
}

const Home = () => (
  <Link to='/other'>Other</Link>
)

const NotFound = () => (
  <div>
    <Link to='/'>Home</Link>
    <p>Not Found</p>
  </div>
)

const App = () => (
  <div>
    <Match pattern='/' exactly component={Home} />
    <Miss component={NotFound} />
  </div>
)

export default () => (
  <HashRouter>
    <Blocker />
  </HashRouter>
);

[alisd23]

Test still failing when up to date in v4 branch (alpha-5)

There was a potential fix in #4067, but it was closed. Also maybe #4136 is related?

[pshrmn]

FWIW this isn't an issue with <MatchGroup> 😉

[mjackson]

I'm afraid this PR is a bit outdated. <Miss> is gone in current v4, huzzah!

[alisd23]

👍