Record scroll position in dispatch to support alternative batch strategies #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recording scroll position in dispatch method is necessary for clients using alternative batching strategies, such as react-raf-batching[1]. With an alternative batching strategy, by the time componentWillUpdate is called, browser may have tried to restore position itself (not always correctly), and the recorded position is thus wrong. Also, don't record position for REPLACE action since there is no way to get back to it. [1]: https://github.com/petehunt/react-raf-batching
|
Do you mean in |
|
@gaearon Ah, I see. ok, let's keep it in |
mjackson
added a commit
that referenced
this pull request
Nov 26, 2014
Record scroll position in dispatch to support alternative batch strategies
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recording scroll position in dispatch method is necessary for clients using alternative batching strategies, such as react-raf-batching.
With an alternative batching strategy, by the time
componentWillUpdateis called, browser may have tried to restore position itself (not always correctly), and the recorded position is thus wrong.This also happens if you don't immediately
renderinsideRouter.runcallback for some reason.This fix records scroll position while it's “fresh”.
Also, don't record position for
REPLACEaction since there is no way to get back to it.