Update req.url to be req.path
#5880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
URL's with query strings don't get matched correctly when using `req.url`. `req.path` is required instead. remix-run#5285
|
Thanks! |
|
np :) thx for the quick review! |
jeresig
pushed a commit
to Khan/react-router
that referenced
this pull request
Aug 29, 2018
URL's with query strings don't get matched correctly when using `req.url`. `req.path` is required instead. remix-run#5285
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL's with query strings don't get matched correctly when using
req.url.req.pathis required instead. This PR simply updates the documentation.#5285