Skip to content

fix: highlight code diff for invoice.jsx #8864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2022
Merged

Conversation

jimniels
Copy link
Contributor

The very last example in the tutorial is highlighting the wrong lines of code.

The last time this file was touched in the tutorial, it looked like this:

CleanShot 2022-05-12 at 11 16 27@2x

Then, when you get to the next place invoices.jsx is edited, the diff highlights are incorrect. Note:

  • 👍 The import diffs is right
  • 👎 Lines 9 and 10 (useNavigate() and useLocation()) were added but not highlighted as additions
  • 👎 Lines 20-29 are highlighted, but line 20 was already there and line 30 was added (but not highlighted).

So this request makes it so the actual code differences are highlighted correctly. Current vs. proposed:

CleanShot 2022-05-12 at 11 22 23@2x

Highlight the proper line differences
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 12, 2022

Hi @jimniels,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 12, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@ryanflorence ryanflorence merged commit 4172a9d into main May 12, 2022
@ryanflorence ryanflorence deleted the jimniels-patch-1 branch May 12, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants