Apply custom headers passed to client constructor #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mattt Zmuda <[email protected]>
mattt
added a commit
that referenced
this pull request
Jun 28, 2024
In #268, we allowed custom headers to be passed to client instances. However, that didn't apply any custom `User-Agent` header. This is now fixed. This PR also updates the README to document how to create a custom client instance, incorporating this new behavior. This PR is an alternative to #304. --------- Signed-off-by: Mattt Zmuda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client.__init__takes a**kwargsargument that gets passed to the underlying httpx client constructor. However, the current implementation doesn't honor any custom headers that are passed. This PR fixes that.