asynchronously close of response #309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alex-does-stuff Ah, nice catch! Thanks for opening this PR. CI is failing because some integration tests require an auth token, but that isn't set in forks. That's a relatively new change, so I'll work on a fix for that. |
mattt
added a commit
that referenced
this pull request
Jun 28, 2024
…316) Unblocks #309 Signed-off-by: Mattt Zmuda <[email protected]>
|
@alex-does-stuff Thanks again for your help. And thanks for your patience in me getting CI sorted. Merging this now 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The response is closed synchronously in the async path, unnecessarily blocking.
The PR closes the response asynchronously instead