Skip to content

Mark all APIs that can throw JS errors with @raises #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zth opened this issue Feb 24, 2023 · 0 comments · Fixed by rescript-lang/rescript#7328
Closed

Mark all APIs that can throw JS errors with @raises #71

zth opened this issue Feb 24, 2023 · 0 comments · Fixed by rescript-lang/rescript#7328
Assignees
@tsnobip

Comments

@zth
Copy link
Collaborator

zth commented Feb 24, 2023

Reanalyze can help us ensure we handle potential exceptions if it knows about what external APIs can throw what. https://rescript-lang.org/syntax-lookup#raises-decorator

Go through the APIs we've bound to and ensure they're all marked with @raises where appropriate.
@zth zth mentioned this issue Mar 10, 2023
Merged
@tsnobip tsnobip self-assigned this Mar 7, 2025
tsnobip added a commit to rescript-lang/rescript that referenced this issue Mar 11, 2025
@tsnobip
update reanalyze exception tracking of stdlib
a44b60c 
Fixes rescript-lang/rescript-core#71
@tsnobip tsnobip mentioned this issue Mar 11, 2025
Merged
tsnobip added a commit to rescript-lang/rescript that referenced this issue Mar 11, 2025
@tsnobip
update reanalyze exception tracking of stdlib
7b74053 
Fixes rescript-lang/rescript-core#71
tsnobip added a commit to rescript-lang/rescript that referenced this issue Mar 11, 2025
@tsnobip
update reanalyze exception tracking of stdlib
3ee6c96 
Fixes rescript-lang/rescript-core#71
fhammerschmidt pushed a commit to rescript-lang/rescript that referenced this issue Apr 4, 2025
@tsnobip @fhammerschmidt
update reanalyze stdlib exception tracking (#7328)
bdd03ba 
* add tests for exception tracking on externals

* add docstring tests to Stdlib.BigInt

* update reanalyze exception tracking of stdlib

Fixes rescript-lang/rescript-core#71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsnobip tsnobip

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update reanalyze stdlib exception tracking rescript-lang/rescript
2 participants
@zth @tsnobip