Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object-docs (consolidated) #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Object-docs (consolidated) #117
Changes from 36 commits
7da0d96
da6197a
8f1d753
5db75f0
2741d73
033d0a6
5b95915
d60469f
8f6db7c
6d36dbf
258abe3
bfa541f
a34df2a
14ea9ed
9a67b0c
b4b3fda
2b52a04
8856175
a251145
a37c1b8
b37ce6b
319e3b5
2d0fb2c
3bca678
5dec67f
08db9a8
6490abd
c8a7ce5
23d7f0e
ffc0a8f
8aa1415
8b7f4cb
90f2a34
6539e1b
d7601b9
6375876
6a59ec2
16bbe60
1e2e296
edb1798
5d2f875
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. And with the potential functions
assign2
,assign3
and such of course.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend removing it and not introducing assign2, assign3, etc. As you noted other places the developer can chain calls to
assign
and get the same result. But I'll do what you recommend. What should I do?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't do what I recommend, but I agree :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand. Who decides this? We both agree to remove it. @zth need your input here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who actually makes the decisions, and how, is just one of many mysteries around ReScript that you'll have to accept. The project has a history of poor management, though it's getting better! But still quite mysterious, unfortunately.
But for this library I suppose it's ultimately whoever has commit access, which is definitely @zth, and I'm sure @cknitt as well.