Improve Core__Type / Add support for BigInt

CHANGELOG.md

@@ -6,6 +6,9 @@
 
 - Map, Set, WeakMap, WeakSet: use the types defined in the Js namespace. https://github.com/rescript-association/rescript-core/pull/143
 - Symbol: use the types defined in the Js namespace. https://github.com/rescript-association/rescript-core/pull/145
+- The types `RescriptCore.Type.function` and `RescriptCore.Type.object` use the types defined in the Js namespace. https://github.com/rescript-association/rescript-core/pull/146
+- The type `RescriptCore.Type.symbol` removed in favor of `RescriptCore.Symbol.t`. https://github.com/rescript-association/rescript-core/pull/146
+- Added `BigInt` support for `RescriptCore.Classify.t`. https://github.com/rescript-association/rescript-core/pull/146
 - `Array` mutable & immutable helper name changed to conform to JS' upcoming APIs [such as `toSorted`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/toSorted)
   - `sort` -> `toSorted`, `sortInPlace` -> `sort`
   - `reverse` -> `toReversed`, `reverseInPlace` -> `reverse`

src/Core__Type.res

@@ -3,9 +3,8 @@ type t = [#undefined | #object | #boolean | #number | #bigint | #string | #symbo
 external typeof: 'a => t = "#typeof"
 
 module Classify = {
-  type function
-  type object
-  type symbol
+  type function = Js.Types.function_val
+  type object = Js.Types.obj_val
 
   type t =
     | Bool(bool)
@@ -15,15 +14,17 @@ module Classify = {
     | Number(float)
     | Object(object)
     | Function(function)
-    | Symbol(symbol)
+    | Symbol(Core__Symbol.t)
+    | BigInt(Core__BigInt.t)
 
   @val external _internalClass: 'a => string = "Object.prototype.toString.call"
   external _asBool: 'a => bool = "%identity"
   external _asString: 'a => string = "%identity"
   external _asFloat: 'a => float = "%identity"
   external _asObject: 'a => object = "%identity"
   external _asFunction: 'a => function = "%identity"
-  external _asSymbol: 'a => symbol = "%identity"
+  external _asSymbol: 'a => Core__Symbol.t = "%identity"
+  external _asBigInt: 'a => Core__BigInt.t = "%identity"
 
   let classify = value => {
     switch _internalClass(value) {
@@ -37,6 +38,7 @@ module Classify = {
     | "[object AsyncFunction]" =>
       Function(_asFunction(value))
     | "[object Symbol]" => Symbol(_asSymbol(value))
+    | "[object BigInt]" => BigInt(_asBigInt(value))
     | _ => Object(_asObject(value))
     }
   }

src/Core__Type.resi

@@ -47,13 +47,6 @@ module Classify: {
   */
   type object
 
-  /**
-  An abstract type representing a JavaScript symbol.
-
-  See [`symbol`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol) on MDN.
-  */
-  type symbol
-
   /**
   The type representing a classified JavaScript value.
   */
@@ -65,7 +58,8 @@ module Classify: {
     | Number(float)
     | Object(object)
     | Function(function)
-    | Symbol(symbol)
+    | Symbol(Core__Symbol.t)
+    | BigInt(Core__BigInt.t)
 
   /**
 `classify(anyValue)`