Skip to content

Rename Object.empty to Object.make #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Conversation

glennsl
Copy link
Contributor

@glennsl glennsl commented Feb 15, 2024

Dict and every other module uses make to create empty collections. For consistency, Object should do the same.

@zth
Copy link
Collaborator

zth commented Feb 15, 2024

Agreed. Thanks!

@zth zth merged commit 2a9586f into rescript-lang:main Feb 15, 2024
@glennsl glennsl deleted the fix/dict/empty branch February 15, 2024 09:12
illusionalsagacity pushed a commit to illusionalsagacity/rescript-core that referenced this pull request Jun 19, 2024
* refactor(object): empty -> make

* docs: update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants