-
Notifications
You must be signed in to change notification settings - Fork 30
Nullable additions #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I like these, I think adding them makes sense. @cknitt thoughts? |
I like these, too, but I think the signature for map and flatMap is incorrect. It is let map: (t<'a>, 'a => 'b) => option<'b>
let flatMap: (t<'a>, 'a => option<'b>) => option<'b> but should be let map: (t<'a>, 'a => 'b) => t<'b>
let flatMap: (t<'a>, 'a => t<'b>) => t<'b> |
Oops. Shows where I've copied them from! I'm also missing the interface file that was added a few days ago, so I need to add signatures there as well. |
c1523fc
to
c0e22ca
Compare
So map and flatMap transform |
I kind of agree, but that requires using |
Looks good to me! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Looks good to you too @cknitt ?
fdfb5a0
to
0ccfb1e
Compare
Co-authored-by: Pedro Castro <[email protected]>
0ccfb1e
to
3136da6
Compare
Ready to merge from my side! BTW, would be nice to have these additions for |
Other monads like
Option
,Result
andList
has them, so I think it makes sense forNullable
to have them too.