Skip to content

Deprecate ReactDOM.props & compat to JSX v4 lowercase #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 1, 2022

Conversation

mununki
Copy link
Member

@mununki mununki commented Sep 29, 2022

This PR deprecates the type ReactDOM.props, and bind the type ReactDOM.domProps to JsxDOM.domProps.
Also, it will change the ReactDOM.createElement* bindings to make compatible with JSX v4 lowercase.

@mununki
Copy link
Member Author

mununki commented Sep 30, 2022

2338941 for aria* attributes of DOM element makes avoiding to use the OCaml expression #_true. Once we can build the compiler lib written in res, then we can rewrite JsxDOM to res.

@cknitt
Copy link
Member

cknitt commented Oct 1, 2022

The domProps type variables thing needs to be reverted again now that we decided in #5706 not to do it.

@mununki
Copy link
Member Author

mununki commented Oct 1, 2022

The domProps type variables thing needs to be reverted again now that we decided in #5706 not to do it.

Done!

@cristianoc
Copy link
Contributor

Merge away

@mununki mununki merged commit 16c5a7b into master Oct 1, 2022
@mununki mununki deleted the jsx-v4-lowercase branch October 1, 2022 06:08
@mununki
Copy link
Member Author

mununki commented Oct 1, 2022

Merge away

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants