Skip to content

bump analysis/test rescript version #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chenglou opened this issue Apr 24, 2021 · 0 comments · Fixed by #164
Closed

bump analysis/test rescript version #126

chenglou opened this issue Apr 24, 2021 · 0 comments · Fixed by #164

Comments

@chenglou
Copy link
Member

Then update makefile to build using rescript directly instead of rescript build -with-deps
chenglou added a commit that referenced this issue Apr 27, 2021
@chenglou
Re-bump rescript version; simplify makefile
06dd77d 
This was done in a1074e1 but lost in a423637

Fixes #126.

Since no-op build is cheap, I took the occasion to simplify the makefile incrementalism (which was kinda wrong before too). Gotta love perf + full build.
@chenglou chenglou mentioned this issue Apr 27, 2021
Merged
chenglou added a commit that referenced this issue Apr 27, 2021
@chenglou
Re-bump rescript version; simplify makefile
50e3fb4 
This was done in a1074e1 but lost in a423637

Fixes #126.

Since no-op build is cheap, I took the occasion to simplify the makefile incrementalism (which was kinda wrong before too). Gotta love perf + full build.
chenglou added a commit that referenced this issue Apr 27, 2021
@chenglou
Re-bump rescript version; simplify makefile
313816c 
This was done in a1074e1 but lost in a423637

Fixes #126.

Since no-op build is cheap, I took the occasion to simplify the makefile incrementalism (which was kinda wrong before too). Gotta love perf + full build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-bump rescript version; simplify makefile rescript-lang/rescript-vscode
1 participant
@chenglou