Signature help #547
Signature help #547
Conversation
|
It's ready for a general review, although I have a couple of more cases to handle here in larger functions. |
|
After some testing, this has some ways to go for larger function bodies. I had another idea - instead of printing a dummy function, extracting types, and calculating offsets that way, what if I simply take the label (type string) that will be the signature help, parse that type definition with the parser again, and let the parser tell me all of the offsets. I think that should work, and also future proof/vastly simplify things. |
|
Sounds like a good thing to try. |
| Printf.sprintf ",\n \"documentation\": %s" | ||
| (stringifyMarkupContent docs)) |
There was a problem hiding this comment.
Poor mans optional prop stringification.
|
@cristianoc ready for your eyes. |
…ight that as active, no matter what is picked up at the cursor
|
Compared to other features, this is a little more elaborate i.e. maintenance cost for the future. |
|
Will pick up this again and finish it soon. |
… temp file mechanism for parsing signature help type label
|
@cristianoc ready for your eyes again. |
It should, there are a few tests for it. Although I haven't tested it extensively. |
|
@cristianoc would you mind having another look? |
* wire up server capability + command for signature help * set up analysis bin command, and needed things from the LS protocol * set up empty signature help test * another test to help distinguish * implement signature help for function applications * changelog + readme * leverage the parser to figure out the parameter offsets * include docs for signature if available * if a function has only one (unlabelled) argument, we can always highlight that as active, no matter what is picked up at the cursor * add debug utilities * get rid of hasPosInclusive * move extractExpApplyArgs to SharedTypes for real * shared function * add way to parse via raw source string in parser, and replace current temp file mechanism for parsing signature help type label * refactor logic some * refactor hover so type expansion can be shared, and integrate into signature help * gate new experimental signature help behind configuration option * comment * changelog
Closes #252
This implements signature help for function applications. Signature help is an "interactive" help hint you get when calling a function, that tells you what parameters the function has, as well as what parameter you're currently filling in, if any. Essentially a hover, but with the current parameter you're working on highlighted.
https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_signatureHelp