Skip to content

Fix issue where doc comment is not shown on hover in case of shadowed identifier #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 3, 2022
Merged

Fix issue where doc comment is not shown on hover in case of shadowed identifier #622

merged 3 commits into from
Nov 3, 2022

Conversation

cristianoc
Copy link
Collaborator

See #621

@cristianoc
Copy link
Collaborator Author

When an id is shadowed, the compiler generates a module constraint for the module where the id is defined.
The constraint contains a type for the id without the doc comment (an attribute), which replaces the one with doc comment.

@cristianoc cristianoc changed the title Add example showing how shadowing affects hovering on doc comments. Fix issue where doc comment is not shown on hover in case of shadowed identifier Nov 3, 2022
@cristianoc cristianoc merged commit da80ba2 into master Nov 3, 2022
@cristianoc cristianoc deleted the exmple_doc_comment_shadowing branch November 3, 2022 10:01
@cristianoc cristianoc mentioned this pull request Dec 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cristianoc