Show Docstrings for completion items #837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this in general! But, I worry about perf. Does this mean that the cmt is processed for every file module that can be found? If so, it's important to test the cases where we complete and get tons of file modules back. Like when completing for "nothing" at the top level for example. Could you bench this somehow? Preferably in a larger project. We could for example consider doing the lookups for only the first X file modules, and do them lazily as needed. |
|
@aspeddro could we check the perf here somehow? |
|
I'll check this week |
|
I changed it to draft bc the implementation is wrong |
|
@aspeddro think we can close this one, I implemented the equivalent via the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neovim:
VSCode:
Related #469
Close #469