Skip to content

Make sure full tests are run on mac. #5420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2022
Merged

Make sure full tests are run on mac. #5420

merged 1 commit into from
Jun 8, 2022

Conversation

cristianoc
Copy link
Collaborator

No description provided.

@cristianoc cristianoc mentioned this pull request Jun 8, 2022
Merged
@cannorin
Copy link
Contributor

cannorin commented Jun 8, 2022

You might want to fix the followings too:

  • L36: runner.name != 'macos-arm'
  • L44: runner.name == 'macos-arm'

I assume runs-on: macos-arm uses a self-hosted runner which is always named macos-arm, but I think these lines can lead to the same kind of confusion in future

@cristianoc cristianoc merged commit 6580f79 into master Jun 8, 2022
@cannorin
Copy link
Contributor

cannorin commented Jun 8, 2022 

success in  cycle
success in  cycle1
success in  zerocycle

🚀 🚀 🚀

@cristianoc cristianoc deleted the ci-name branch June 8, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cristianoc @cannorin