Skip to content

V4 classic as default #5595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

V4 classic as default #5595

wants to merge 1 commit into from

Conversation

mununki
Copy link
Member

@mununki mununki commented Aug 6, 2022

This PR makes the jsx ppx v4 + classic mode as default. The related discussion is #5505
Here are the cases of how the jsx ppx is activated.

  1. Old config reason.react_jsx -> V4 + classic
  2. New config -> V4 + classic or automatic as it configures
  3. No config -> not activated.

@mununki
Copy link
Member Author

mununki commented Aug 6, 2022

The jsx ppx is not activated if the jsx config(old or new) doesn't exist.
Still not sure about making the v4 classic as default when the configuration about jsx doesn't exist. It will make one thing less for the new comer to learn, but the jsx ppx is always activated even if it is unnecessary.

@cristianoc
Copy link
Collaborator

cristianoc commented Aug 6, 2022

The jsx ppx is not activated if the jsx config(old or new) doesn't exist.
Still not sure about making the v4 classic as default when the configuration about jsx doesn't exist. It will make one thing less for the new comer to learn, but the jsx ppx is always activated even if it is unnecessary.

I went back to the discussion, and there was no agreement to do this.
It seems to be one certain thing and one uncertain thing.

  • certain: this is a breaking change
  • uncertain: there are also advantages to do this

If you wish to go ahead with this change, better first get consensus from the forum, as that's more then 2 opinions.

@mununki
Copy link
Member Author

mununki commented Aug 7, 2022

Oh, sorry, I misunderstood. I thought we had an agreement. I'll hold this PR as a draft, but I'll ask the community about the V4 as default. It is worth asking.

@mununki mununki marked this pull request as draft August 7, 2022 00:49
@mununki
Copy link
Member Author

mununki commented Sep 13, 2022

This PR can be closed due to introducing #5661

@mununki mununki closed this Sep 13, 2022
@mununki mununki deleted the v4-default branch September 14, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants