Skip to content

Proof of concept: support directives. #5998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Proof of concept: support directives. #5998

merged 1 commit into from
Feb 10, 2023

Conversation

cristianoc
Copy link
Collaborator

Allow to specify directives emitted verbatim at the top of generated js files.

See #5840

@cristianoc
Copy link
Collaborator Author

Should directives be emitted before or after 'use strict', if any.
Should one support command-line too?

@zth
Copy link
Collaborator

zth commented Feb 10, 2023

Should directives be emitted before or after 'use strict', if any. Should one support command-line too?

I think it's good if directives are emitted on top of 'use strict', if it's also being emitted. Command line?

Copy link
Collaborator

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the tests to output 'use client';, since that's the main thing this is for.

Allow to specify directives emitted verbatim at the top of generated js files.

See #5840
@cristianoc cristianoc merged commit 457aeff into master Feb 10, 2023
@cristianoc cristianoc deleted the directives branch February 10, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants