Skip to content

Add missing HTML attribute capture to JsxDOM.res #6004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

edelvalle
Copy link
Contributor

Copy link
Collaborator

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cknitt
Copy link
Member

cknitt commented May 26, 2024

Sorry, this is coming very late 🙈, I am currently cleaning up the open PRs.

Could you rebase @edelvalle?
This needs to go into both jsxDOMC.res and jsxDOMU.res now.

@cknitt
Copy link
Member

cknitt commented Sep 3, 2024

This needs to go into both jsxDOMC.res and jsxDOMU.res now.

Actually with ReScript 12 (uncurried only) we are back at just jsxDOM.res. 🎉
CHANGELOG entry is missing too, though.
I'll create a new PR including a CHANGELOG entry.

@cknitt
Copy link
Member

cknitt commented Sep 3, 2024

Superseded by #7006.

@cknitt cknitt closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants