Remove the transformation of application using opaqueFullApply from the compiler's PPX.
#6893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
force-pushed
the
test-remove-opaque-full-apply
branch
2 times, most recently
from
18e39dd to
5c985f7
Compare
cknitt
reviewed
Jul 22, 2024
jscomp/gentype_tests/typescript-react-example/src/BucklescriptAnnotations.res.js
Outdated
Show resolved
Hide resolved
jscomp/gentype_tests/typescript-react-example/src/nested/Types.res.js
Outdated
Show resolved
Hide resolved
cristianoc
changed the title
opaqueFullApply from the compiler's PPX.
cristianoc
force-pushed
the
test-remove-opaque-full-apply
branch
from
797bbda to
6488556
Compare
The effect is that a bunch of applications are treated as curried applications.
Opaque full apply was still used in the case of partial application `foo(x, ...)`. With the last use gone, the `Js.Internal` module can be removed. One less piece of magic.
cristianoc
force-pushed
the
test-remove-opaque-full-apply
branch
from
6488556 to
8504ebc
Compare
The effect is that a bunch of applications are treated as curried applications.
cknitt
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the transformation of
foo(1,2)intoJs.Internal.opaqueFullApply(Internal.opaque(f), 1, 2).