fix JSBigInt payload type
#6911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
reviewed
Jul 24, 2024
Only if someone is directly reference the It was introduced directly by myself in #5351 , and as far as I know I am the only user. This is not very practical since there was no bigint support, and always involves a coercion to |
|
Or we can just leave |
cristianoc
approved these changes
Jul 24, 2024
cometkim
force-pushed
the
classify-bigint-value
branch
from
a4dd3f6 to
8322b2b
Compare
cknitt
pushed a commit
to cknitt/rescript
that referenced
this pull request
Jul 26, 2024
cknitt
pushed a commit
to cknitt/rescript
that referenced
this pull request
Jul 26, 2024
cknitt
pushed a commit
to cknitt/rescript
that referenced
this pull request
Jul 26, 2024
cknitt
pushed a commit
to cknitt/rescript
that referenced
this pull request
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently its payload isn't useful, because the
bigint_valis opaque (by resi)