Fix issue with pattern matching empty list which interferes with bool… #7237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ean optimisations.
The pattern matching case for empty list `switch x { | list{} =>` used to compile to `if(x)`, which interferes with boolean optimisation.
Now it compiles to `if(x ==0)` which is the same output as for `if(x == list{})`.
Fixes #7235
cristianoc
commented
Jan 9, 2025
| @@ -612,3 +612,11 @@ let sort_uniq = (cmp, l) => { | |||
| sort(len, l) | |||
| } | |||
| } | |||
|
|
|||
| let isEmpty = x => | |||
There was a problem hiding this comment.
This function now compiles to the same code as isEmpty2 below.
cristianoc
force-pushed
the
pattern-match-empty-list
branch
from
09ee5e4 to
92f9d1d
Compare
5 tasks
zth
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ean optimisations.
The pattern matching case for empty list
switch x { | list{} =>used to compile toif(x), which interferes with boolean optimisation. Now it compiles toif(x ==0)which is the same output as forif(x == list{}).Fixes #7235