Remove res partial #7240
Merged
Remove res partial #7240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
commented
Jan 10, 2025
| @@ -3708,45 +3705,6 @@ and parse_call_expr p fun_expr = | |||
| None; | |||
| }; | |||
| ] | |||
| | [ | |||
There was a problem hiding this comment.
Old unnecessary case: foo() is supported.
| LongModuleName.functionWithAlongNameThatWrapsTheEditorToTheNextLinexxxxxxxxxxxxxxxxxxxxxx(d), | ||
| ... | ||
| ) | ||
| let g = f( |
There was a problem hiding this comment.
These differences likely due to the fact that there's no attribute on the application node anymore, so some attribute logic used for printing does not kick in anymore.
| (eq(__LOC__, 6, ...))(f1(1)(2, 3)) | ||
| (eq(__LOC__, 6, ...))(f2(1, 2)(3)) | ||
| (eq(__LOC__, 6, ...))(f3(1)(2, 3)) | ||
| eq(__LOC__, 6, ...)(f0(1, 2, 3)) |
There was a problem hiding this comment.
After formatting. Again attribute logic likely causing this (positive) change.
zth
approved these changes
Jan 10, 2025
cknitt
approved these changes
Jan 10, 2025
cristianoc
force-pushed
the
remove_res_partial
branch
from
da520f4 to
b38c908
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare to remove
@res.partial.Add
partialboolean to untyped and typed ASTs and propagate the partial information.Then remove
@res.partialentirely.