Fix type of RegExp.Result.matches #7393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mediremi
force-pushed
the
regexp-result-matches-type
branch
from
d39996e to
10d9d1f
Compare
mediremi
force-pushed
the
regexp-result-matches-type
branch
from
10d9d1f to
aae95ea
Compare
mediremi
force-pushed
the
regexp-result-matches-type
branch
from
dec17a4 to
0025d93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the type
RegExp.Result.t(array<option<string>>) is correct,matcheswas typed asarray<string>even though it can containundefined.I've also used this PR to make
RegExp.fromStringmore ergonomic by adding an optionalflagsargument and deprecatingRegExp.fromStringWithFlags.