-
Notifications
You must be signed in to change notification settings - Fork 465
Per-platform binary packages #7395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cometkim
wants to merge
26
commits into
rescript-lang:master
Choose a base branch
from
cometkim:per-platform
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
63a5b46
wip
cometkim b05b758
per-platform packages
cometkim 1e52560
fix gentype makefile
cometkim 759c7d8
change binary package exports
cometkim 71538bd
use yarn pack
cometkim 031e3f0
upload platform artifacts
cometkim 97eb93d
fix format
cometkim 777a213
fix flag
cometkim 210961b
suppress warnings from biome
cometkim 636c929
expose bsb_helper path
cometkim 59c41fc
compute realpath of binaries as needed
cometkim 614065f
reduce lstats in tests
cometkim 4e4e703
exclude unintended path from packages
cometkim c2a0e9f
fix package script
cometkim e088280
fix installation test
cometkim e672a20
add typescript declarations
cometkim a4eb634
tmp: search stdlib
cometkim e7c1064
sync versions
cometkim fd1d2d7
gotcha
cometkim 0e06919
a bit safer
cometkim e5aee82
it shound't be symlinks
cometkim f68c0fa
Overlapped bin entries is not compatibile with the mult-arch config
cometkim d1eafac
workaround for executable permission
cometkim 790cb7d
actually not needed
cometkim f8f7d14
update lockfile
cometkim 9aabc9f
handle path correctly
cometkim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
#!/usr/bin/env bash | ||
|
||
set -e | ||
|
||
check_statically_linked() { | ||
local dir=$1 | ||
local all_statically_linked=true | ||
|
||
for file in "$dir"/*; do | ||
if [ -f "$file" ]; then | ||
if file "$file" | grep -Eq "statically linked|static-pie linked"; then | ||
echo "$file is statically linked." | ||
else | ||
echo "$file is NOT statically linked." | ||
all_statically_linked=false | ||
fi | ||
fi | ||
done | ||
|
||
if $all_statically_linked; then | ||
echo "All files in $dir are statically linked executables." | ||
else | ||
echo "Error: Not all files in $dir are statically linked executables." | ||
exit 1 | ||
fi | ||
} | ||
|
||
clean_dir() { | ||
local dir="$1" | ||
rm -rf "$dir" && mkdir -p "$dir" | ||
echo -n "$dir" | ||
} | ||
|
||
# rescript | ||
mv lib-ocaml lib/ocaml | ||
|
||
# @rescript/{target} | ||
chmod +x binaries-*/*.exe rewatch-*/*.exe | ||
mv -f binaries-darwin/* rewatch-darwin/* "$(clean_dir "packages/@rescript/darwin-x64/bin")" | ||
mv -f binaries-darwinarm64/* rewatch-darwinarm64/* "$(clean_dir "packages/@rescript/darwin-arm64/bin")" | ||
mv -f binaries-linux/* rewatch-linux/* "$(clean_dir "packages/@rescript/linux-x64/bin")" | ||
mv -f binaries-linuxarm64/* rewatch-linuxarm64/* "$(clean_dir "packages/@rescript/linux-arm64/bin")" | ||
mv -f binaries-win32/* rewatch-win32/* "$(clean_dir "packages/@rescript/win32-x64/bin")" | ||
check_statically_linked "packages/@rescript/linux-x64/bin" | ||
check_statically_linked "packages/@rescript/linux-arm64/bin" | ||
|
||
# @rescript/std | ||
mkdir -p packages/std/lib | ||
cp -R lib/es6 lib/js packages/std/lib |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to use GitHub's package registry for nightly builds