-
Notifications
You must be signed in to change notification settings - Fork 38
Print attributes without the @bs prefix #230
Conversation
This is generally very cool and good but could it be all-or nothing across annotations? Having a consistently inferior syntax is better than an inconsistent-occasionally nicer syntax (which is already a massive issue with existing *.re code that must share a codebase with any .res for the foreseeable future). |
@pckilgore can you explain yourself more? I included all annotations, except for |
Even a deprecated construct might be supported for years. Unless there's a technical reason to not convert to
|
@pckilgore we will document the bs.send.pipe and bs.open as deprecated attributes in our syntax widget, so ppl will still have a chance to understand what those are for, or why they are printed differently. The compiler will also most likely print a deprecation warning at some point? \cc @bobzhang |
I suppose I'm still curious why not treat them consistently and obviate any possible confusion (and also avoid the need to clutter the documentation with information that will be irrelevant to most). |
e9105a4
to
94de392
Compare
It's ok here and won't cause a lot of confusion. The documentation will contain both versions any way. Regarding the |
before
after
Exceptions: