This repository was archived by the owner on Jun 15, 2023. It is now read-only.
Remove printing of arrow functions with "multiple" dots #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arrow functions with multiple dots `(. a, . b) => a + b` are considered an anti-pattern. This syntax *will be removed* in the future. As a first step, the printer will know print this as multiple arrow functions. (Like in JavaScript) **Before** ```rescript let f = (. a, . b) => a + b type f = (. int, . int) => int ``` **After** ```rescript let f = (. a) => (. b) => a + b type f = (. int) => (. int) => int ```
cristianoc
reviewed
Oct 3, 2022
src/res_parsetree_viewer.ml
Outdated
| ptyp_desc = Ptyp_arrow ((Nolabel as lbl), typ1, typ2); | ||
| ptyp_attributes = [({txt = "bs" | "res.async"}, _)] as attrs; | ||
| ptyp_desc = Ptyp_arrow (Nolabel, _typ1, _typ2); | ||
| ptyp_attributes = [({txt = "bs" | "res.async"}, _)]; |
There was a problem hiding this comment.
Can you add examples of nested async functions?
There was a problem hiding this comment.
Not sure what that is doing here. type f = async (…) => … does not exist. Will remove.
There was a problem hiding this comment.
Done in def9fa0
Type expressions can't use the "async" keyword.
cristianoc
approved these changes
Oct 3, 2022
|
Would you add a line to the changelog and merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arrow functions with multiple dots
(. a, . b) => a + bare considered an anti-pattern. This syntax will be removed in the future. As a first step, the printer will know print this as multiple arrow functions. (Like in JavaScript)Before
After