fix(react-email): Dependents of dependents of email templates not causing hot reloads #2083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielmfern
added
the
Package: react-email
🦋 Changeset detectedLatest commit: 6685b5b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gabrielmfern
deleted the
feature/eng-4073-fix-dependents-of-dependents-of-email-templates-not
branch
bukinoshita
pushed a commit
that referenced
this pull request
Apr 19, 2025
…sing hot reloads (#2083)
gabrielmfern
added a commit
that referenced
this pull request
Apr 23, 2025
…sing hot reloads (#2083)
gabrielmfern
added a commit
that referenced
this pull request
Apr 23, 2025
…sing hot reloads (#2083)
gabrielmfern
added a commit
that referenced
this pull request
Apr 23, 2025
…sing hot reloads (#2083)
gabrielmfern
added a commit
that referenced
this pull request
Apr 24, 2025
…sing hot reloads (#2083)
gabrielmfern
added a commit
that referenced
this pull request
Apr 24, 2025
…sing hot reloads (#2083)
gabrielmfern
added a commit
that referenced
this pull request
Apr 24, 2025
…sing hot reloads (#2083)
gabrielmfern
added a commit
that referenced
this pull request
Apr 25, 2025
…sing hot reloads (#2083)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meant for #2078.
The main problem was that the component was being treated as an email template on the hot reloading code which is then fixed with
react-email/packages/react-email/src/hooks/use-email-rendering-result.ts
Lines 32 to 36 in fe84d5c
Alongside a unit test to ensure this function works as intended. This PR also ends up fixing the error in #1872 (comment)