Skip to content

Allow unknown certificate #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rafi opened this issue Aug 8, 2021 · 5 comments · Fixed by #264
Closed

Allow unknown certificate #46

rafi opened this issue Aug 8, 2021 · 5 comments · Fixed by #264
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@rafi
Copy link

rafi commented Aug 8, 2021

Is there a way to force curl -k to skip ssl verification?

@NTBBloodbath
Copy link
Member

Hey, sorry for the late reply!

There should but I'm not really sure about how should we implement this because it will need some extra logic. Maybe adding a new option to our run() function? It makes sense for me but let me know if it's fine for you.

Regards

@NTBBloodbath NTBBloodbath added enhancement New feature or request good first issue Good for newcomers labels Aug 10, 2021
@rafi
Copy link
Author

rafi commented Aug 12, 2021

Hi, either a run() argument or a global setup() setting would be great @NTBBloodbath.

@NTBBloodbath
Copy link
Member

Now that you mention it, I think a setup() setting could be a better approach because we will avoid having to create new mappings or modify the existing ones 🤔

@rafi
Copy link
Author

rafi commented Aug 15, 2021

Yes, sounds like an easier solution than complicating run().

@NTBBloodbath
Copy link
Member

Great, I'll start implementing it today, shouldn't be hard tho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants