-
-
Notifications
You must be signed in to change notification settings - Fork 148
fix parsing of nested tables and curl arguments #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @teto, hope you're doing well (and sorry for the mention). Do you think it's worth it merging this one? I was checking the PRs that are open and found #120 (that is yours) and it does fix body send by sending the whole body as a string. Would your PR fix this problem and many others too? If so, we could update your PR branch and merge that one instead and close this one in favor of #120. |
@NTBBloodbath the issue that #120 was trying to solve has already been fixed by my previous PR #125. This PR fixes errors when you try to include json values in |
I was wondering if my PR was still relevant, thanks for addressing this. Could you add a test that fails without this please ? |
I have added a test |
@NTBBloodbath any updates on this PR? I have also added another commit that fixes parsing of curl arguments with spaces in them. For example: GET http://localhost:8000/
-c cookies the above request will create file This also allows for more complex queries like: GET http://localhost:8000/
-c some\ cokkie\ file -u user:password |
Hey, sorry for the late reply! Thought actual codebase rewrite would take less time (it's still in its time to wear diapers, but I'm making very good decisions behind the scenes!) so I didn't want to merge any actual PR in order to keep codebase simpler to track for me, however, that's not the case right now and we gotta merge these fixes and some new features as people really needs them. Also thank you so much for this PR changes, everything looks good to me. Thank you again for fixing cURL arguments parsing too! |
Fixes errors when you pass array or object in request body without setting request body to
application/json
, for example:would result in following error:
but this PR fixes it and gives the following query: