Skip to content

#141: fixes header name #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2022
Merged

#141: fixes header name #142

merged 1 commit into from
Nov 25, 2022

Conversation

appelgriebsch
Copy link
Contributor

Instead of converting the captured header name to lowercase using it the way it is spelled in the document.

Copy link
Member

@NTBBloodbath NTBBloodbath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this PR!

@NTBBloodbath NTBBloodbath linked an issue Nov 25, 2022 that may be closed by this pull request
@NTBBloodbath NTBBloodbath merged commit cf4bcd8 into rest-nvim:main Nov 25, 2022
@appelgriebsch appelgriebsch deleted the fix-header-names branch November 29, 2022 09:53
@teto
Copy link
Collaborator

teto commented Dec 20, 2022

as mentioned in the related PRs, this breaks rest-nvim so what was the motivation in the first place ?

@rochacbruno
Copy link
Contributor

I spent some good minutes trying to figure out what was wrong with my API code and it was just this.

Maybe add to the docs.

Headers must be lowercase

- Content-Type: application/json
+ content-type: application/json

Which makes no sense, HTTP std accepts capital headers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Touches names of Header values
4 participants