Skip to content

fix formatter for html and error in rest.run() #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

fix formatter for html and error in rest.run() #165

wants to merge 3 commits into from

Conversation

udayvir-singh
Copy link
Contributor

@udayvir-singh udayvir-singh commented Dec 29, 2022 •
edited
Loading

Fixes error caused by html formatter running even when tidy is not available on the system. Also fixes docs related to disabling formatters.

fixes #164

@udayvir-singh
config: fix formatter for html
052d68a 
Fixes error caused by html formatter running even when tidy is not
available on the system. Also fixes docs related to disabling
formatters.
@udayvir-singh udayvir-singh mentioned this pull request Dec 29, 2022
Merged
@udayvir-singh
fix: really stupid errors
3d2c520 
Adds debug<boolean> opt in config to show optionally show debug messages.

Fixes rest.run showing errors because it was passing an argument of type
<boolean> to rest.run_request instead of the expected <table>.
@udayvir-singh udayvir-singh changed the title config: fix formatter for html config: fix formatter for html and error in rest.run() Dec 29, 2022
@udayvir-singh udayvir-singh changed the title config: fix formatter for html and error in rest.run() fix formatter for html and error in rest.run() Dec 29, 2022
@udayvir-singh
Copy link
Contributor Author

udayvir-singh commented Dec 29, 2022 •
edited
Loading

Now this PR also fixes #165 and nasty errors on rest.run() due to incorrect handling of opts.

@udayvir-singh udayvir-singh reopened this Dec 29, 2022
ray-x
ray-x reviewed Dec 29, 2022
View reviewed changes
Copy link

@ray-x ray-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. the changes fix #164

ray-x
ray-x approved these changes Dec 29, 2022
View reviewed changes
Copy link

@ray-x ray-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teto
Copy link
Collaborator

teto commented Dec 29, 2022 •
edited
Loading

you can drop the second commit. I think it's best to throw an error if tidy is not available, so nothing to change on that side, what I am curious about is why html = nil didn't work (that's the way to remove entries from lua arrays). I believe it might be due to how tbl_deep_extend works in config = vim.tbl_deep_extend("force", config, user_configs) but I haven't investigated. Will do if you dont know.

NB: Sry for the close, my browser focused the closed button before I typed Enter :s

@teto teto closed this Dec 29, 2022
@teto teto reopened this Dec 29, 2022
@udayvir-singh udayvir-singh closed this by deleting the head repository Dec 30, 2022
@udayvir-singh udayvir-singh mentioned this pull request Dec 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ray-x ray-x ray-x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable debug logs?
3 participants
@udayvir-singh @teto @ray-x