This repository was archived by the owner on Apr 18, 2024. It is now read-only.
Minor bug fix for incorrectly named schema variable #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
./README.md should also be updated with the schema parameter. |
|
Done! 👍 |
|
You missed renaming access_token_header_as_bearer in README.md line 227 |
|
Fixed, thanks @daverck |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
access_token_header_as_bearerseems to be incorrectly named. As a result configuring the "access token header as bearer" parameter in the oidc plugin has no effect on the plugin's behaviour.It seems like the variable should be named
access_token_as_bearerinstead as referencedkong/plugins/oidc/utils.lua.