API to work with Exchange to Exchange bindings #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RabbitMQ has a special extension for AMQP protocol which allows you to have bindings between two exchanges (apart of exchange to queue bindings). This feature also available through Management plugin HTTP API. But unfortunately not implemented by this library.
I have added methods to work with exchange-to-exchange bindings.
I like your single word naming convention for API endpoints but I couldn't follow it with exchange-to-exchange bindings. I didn't want to add one more parameter to existing methods, and create heavy API so I just copied methods for exchange-to-queue bindings with
Exchangesuffix. Not sure if it's the right approach though.