Skip to content

Bump Binutils into 2.44. #1676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Bump Binutils into 2.44. #1676

wants to merge 2 commits into from

Conversation

pz9115
Copy link
Contributor

@pz9115 pz9115 commented Feb 20, 2025

Bump Binutils into 2.44.

@cmuellner
Copy link
Collaborator

Thanks for reminding me.
I have a glibc version bump ready as well.

Makefile.in Outdated
@@ -346,6 +346,7 @@ endif

$(srcdir)/%/.git:
cd $(srcdir) && \
flock `git rev-parse --git-dir`/config git fetch --all && \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this should not belong this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there exist shallow clone missing commit problem in CI, I'm trying to fix it.
#1669

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also see the more detailed commentary from @mickflemm on the shallow clone problem here:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thank you Tommy.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The question here is, how do we deal with "not advertised" git references?

I don't want a downstream script that checks if we can fetch a commit or need to find out the proper branch first. If the upstream server does not support a simple shallow-clone-workflow, then what's the point in insisting on shallow clones?

I think dropping the shallow = true for servers that make things harder than necessary is reasonable.

We could justify each of these in a comment ("We don't use shallow clones for Binutils, because the git server does not support fetching unadvertised git objects").

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think dropping the shallow = true for servers that make things harder than necessary is reasonable

That alone would not be sufficient to stop doing a shallow clone for specific submodules.
This line in Makefile.in would also need appropriate modification:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants