-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Bump Binutils into 2.44. #1676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Binutils into 2.44. #1676
Conversation
Thanks for reminding me. |
Makefile.in
Outdated
@@ -346,6 +346,7 @@ endif | |||
|
|||
$(srcdir)/%/.git: | |||
cd $(srcdir) && \ | |||
flock `git rev-parse --git-dir`/config git fetch --all && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this should not belong this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there exist shallow clone missing commit problem in CI, I'm trying to fix it.
#1669
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also see the more detailed commentary from @mickflemm on the shallow clone problem here:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thank you Tommy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The question here is, how do we deal with "not advertised" git references?
I don't want a downstream script that checks if we can fetch a commit or need to find out the proper branch first. If the upstream server does not support a simple shallow-clone-workflow, then what's the point in insisting on shallow clones?
I think dropping the shallow = true
for servers that make things harder than necessary is reasonable.
We could justify each of these in a comment ("We don't use shallow clones for Binutils, because the git server does not support fetching unadvertised git objects").
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think dropping the
shallow = true
for servers that make things harder than necessary is reasonable
That alone would not be sufficient to stop doing a shallow clone for specific submodules.
This line in Makefile.in
would also need appropriate modification:
riscv-gnu-toolchain/Makefile.in
Line 350 in a33dac0
flock `git rev-parse --git-dir`/config git submodule update --progress --depth 1 $(dir $@)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bump Binutils into 2.44.