Fix setting of RSP_ENABLE flag in set_frame_entry #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the RSP_ENABLE flag was only set if it was already present in the flags parameter. Otherwise, no flags were set. With this commit, flags are always set and the RSP_ENABLE flag is additionally set if the direction is PUBLISHER.
|
nice catch, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
thanks for publishing the library. I found it quite helpful for working with the PLIN driver directly from Python.
I stumbled upon a bit of an issue with the
RSP_ENABLEflag: at the moment, theRSP_ENABLEflag is only passed to the kernel if it's already present in theflagsparameters. If not, nothing is passed. I assume this might be a typo mistake where&was used instead of|.I propose a fix to the function as well as a unit test to validate the implementation. If you don't mind, I can also make an additional folder called
tests/integrationin which the existing tests can go.