-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Remove “form-group field field-object” classnames from SchemaField #2280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This issue has been automatically marked as possibly close because it has not had recent activity. It will be closed if no further activity occurs. Please leave a comment if this is still an issue for you. Thank you. |
I'm running into this. It's causing problems in an app that uses both MUI and Bootstrap where I want to use the MUI theme and use no bootstrap styles--this causes issues because In a future major version, we could consider only adding class names in templates (i.e. hard-coded class names should not be added at the field level) |
One could wrap the existing component(s) and programmatically remove the classnames, but ideally I would like for us to remove classnames from fields in v6 |
Move to from the template into the field |
This issue has been automatically marked as possibly close because it has not had recent activity. It will be closed if no further activity occurs. Please leave a comment if this is still an issue for you. Thank you. |
Related to #4492 |
Fixed #2280 by moving marker classes from `SchemaField` to `WrapIfAdditionalTemplate` - In `@rjsf/utils`, updated `WrapIfAdditionalTemplateProps` to pick up the `hideError` and `rawErrors` props from `FieldTemplateProps` - In `@rjsf/core`, updated `SchemaField` to move the `form-group` and `field` marker classes to the `WrapIfAdditionalTemplate` - Also moved the `field-error`, `has-error` and `has-danger` error marker classes - Updated the grid snapshot due to the change - Updated the snapshots in other themes due to the removed marker classes - Updated the `CHANGELOG_v6.md` and `v6x upgrade guide.md` to reflect these changes
Fixed #2280 by moving marker classes from `SchemaField` to `WrapIfAdditionalTemplate` - In `@rjsf/utils`, updated `WrapIfAdditionalTemplateProps` to pick up the `hideError` and `rawErrors` props from `FieldTemplateProps` - In `@rjsf/core`, updated `SchemaField` to move the `form-group` and `field` marker classes to the `WrapIfAdditionalTemplate` - Also moved the `field-error`, `has-error` and `has-danger` error marker classes - Updated the grid snapshot due to the change - Updated the snapshots in other themes due to the removed marker classes - Updated the `CHANGELOG_v6.md` and `v6x upgrade guide.md` to reflect these changes
* Fix 2280 by moving the bootstrap 3 marker classes out of SchemaField Fixed #2280 by moving marker classes from `SchemaField` to `WrapIfAdditionalTemplate` - In `@rjsf/utils`, updated `WrapIfAdditionalTemplateProps` to pick up the `hideError` and `rawErrors` props from `FieldTemplateProps` - In `@rjsf/core`, updated `SchemaField` to move the `form-group` and `field` marker classes to the `WrapIfAdditionalTemplate` - Also moved the `field-error`, `has-error` and `has-danger` error marker classes - Updated the grid snapshot due to the change - Updated the snapshots in other themes due to the removed marker classes - Updated the `CHANGELOG_v6.md` and `v6x upgrade guide.md` to reflect these changes * - prefixed all rjsf marker classes with `rjsf-` * - Added `field-hidden` to docs * - Fixed build by redoing snapshots after running build
Below is the custom template code I have given to the json schema form. For objects in the form schema, it automatically creates a divi with the form-group field field-object class and MuiGrid-root MuiGrid-container MuiGrid-spacing-xs-3 class. I don't want these to happen. I want all items to be lined up side by side (MuiGrid-root MuiGrid-item MuiGrid-grid-xs-6). How can I do it.
The text was updated successfully, but these errors were encountered: