fix: Call latest onChange #1755
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirkov
force-pushed
the
call-next-props-onchange
branch
from
0930a0b to
9ba4c3a
Compare
|
@epicfaace Added a test. It was I bit tricky to trigger the condition for the |
|
This is still valid, I just haven't reviewed it yet. |
heath-freenome
added a commit
to heath-freenome/react-jsonschema-form
that referenced
this pull request
Aug 26, 2022
- Reimplement two fixes related to `onChange` in the new `Form.tsx` - rjsf-team#1755 fixes the calling of the proper `onChange` during props update - rjsf-team#2460 fixes race condition on calling `onChange` after setState.
heath-freenome
added a commit
to heath-freenome/react-jsonschema-form
that referenced
this pull request
Aug 26, 2022
- Reimplement two fixes related to `onChange` in the new `Form.tsx` - rjsf-team#1755 fixes the calling of the proper `onChange` during props update - rjsf-team#2460 fixes race condition on calling `onChange` after setState.
8 tasks
heath-freenome
added a commit
to heath-freenome/react-jsonschema-form
that referenced
this pull request
Aug 26, 2022
- Reimplement two fixes related to `onChange` in the new `Form.tsx` - rjsf-team#1755 fixes the calling of the proper `onChange` during props update - rjsf-team#2460 fixes race condition on calling `onChange` after setState.
heath-freenome
added a commit
to heath-freenome/react-jsonschema-form
that referenced
this pull request
Aug 26, 2022
- Reimplement two fixes related to `onChange` in the new `Form.tsx` - rjsf-team#1755 fixes the calling of the proper `onChange` during props update - rjsf-team#2460 fixes race condition on calling `onChange` after setState.
heath-freenome
added a commit
to heath-freenome/react-jsonschema-form
that referenced
this pull request
Aug 27, 2022
…sf-team#3052) - Reimplement two fixes related to `onChange` in the new `Form.tsx` - rjsf-team#1755 fixes the calling of the proper `onChange` during props update - rjsf-team#2460 fixes race condition on calling `onChange` after setState.
|
Reimplemented in v5 beta due to typescript conversion via #3052 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fixes the issue described in #1708
Checklist