-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Update react peer dependency to be 16.8.0 so hooks can be used in this repo. #2456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
ssbyoung
wants to merge
2
commits into
rjsf-team:master
from
ssbyoung:ssbyoung/react-hooks-peer-dependency
Closed
Update react peer dependency to be 16.8.0 so hooks can be used in this repo. #2456
ssbyoung
wants to merge
2
commits into
rjsf-team:master
from
ssbyoung:ssbyoung/react-hooks-peer-dependency
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would probably be a breaking change, though. |
@epicfaace all of the packages under the covers are developing against at least 16.8.0. I initially tried to upgrade to react 17, but I think there are issues with |
Could you clarify what you meant by "all of the packages under the covers"?
Not quite sure what you meant.
…--
Ashwin Ramaswami
On Thu, Jul 1, 2021 at 11:33 AM Broderick Young ***@***.***> wrote:
@epicfaace <https://github.com/epicfaace> all of the packages under the
covers are developing against at least 16.8.0. I initially tried to upgrade
to react 17, but I think there are issues with ReactIs.isMemo in core
that were giving me headaches.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2456 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAM4MXZCPZ6HDM4K4LT7L3DTVSDFBANCNFSM47U4KIMA>
.
|
This was referenced Jul 1, 2021
@epicfaace what is the best way to get my PR's in front of reviewers? |
Closing this PR as the one that requires it is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
I am planning on making a change to fix #2449. Want to be able to use hooks in the feature I'm writing.
Checklist