Skip to content

Update react peer dependency to be 16.8.0 so hooks can be used in this repo. #2456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ssbyoung
Copy link

@ssbyoung ssbyoung commented Jul 1, 2021

Reasons for making this change

I am planning on making a change to fix #2449. Want to be able to use hooks in the feature I'm writing.

Checklist

  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed

@epicfaace
Copy link
Member

This would probably be a breaking change, though.

@ssbyoung
Copy link
Author

ssbyoung commented Jul 1, 2021

@epicfaace all of the packages under the covers are developing against at least 16.8.0. I initially tried to upgrade to react 17, but I think there are issues with ReactIs.isMemo in core that were giving me headaches.

@epicfaace
Copy link
Member

epicfaace commented Jul 1, 2021 via email

@ssbyoung
Copy link
Author

ssbyoung commented Jul 2, 2021

@epicfaace what is the best way to get my PR's in front of reviewers?

@epicfaace
Copy link
Member

@ssbyoung See #2418!

As for #2449, it's going to take longer to merge / release if it requires bumping a peer dependency -- i.e., it would need to wait until v4, which might take a couple months at least. Is hooks the only way to do it?

@ssbyoung
Copy link
Author

Closing this PR as the one that requires it is no longer needed.

@ssbyoung ssbyoung closed this Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui:emptyValue does not work when initial data has an empty string
2 participants